Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow skipping events that are not reportable #340

Merged
merged 1 commit into from
Dec 13, 2023
Merged

Allow skipping events that are not reportable #340

merged 1 commit into from
Dec 13, 2023

Conversation

xsuchy
Copy link
Contributor

@xsuchy xsuchy commented Nov 16, 2023

e.g. lunch break, focus block, deadline reminders

psss
psss requested changes Dec 4, 2023
View reviewed changes
Copy link
Owner

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the improvement! Just two suggestions.

did/stats.py Outdated Show resolved Hide resolved
did/plugins/google.py Outdated Show resolved Hide resolved
@psss psss changed the title allow skipping events that are not reportable Allow skipping events that are not reportable Dec 4, 2023
@psss psss added this to the 0.22 milestone Dec 4, 2023
@psss psss self-assigned this Dec 4, 2023
@xsuchy
Copy link
Contributor Author

xsuchy commented Dec 5, 2023

Updated.

psss
psss approved these changes Dec 13, 2023
View reviewed changes
Copy link
Owner

@psss psss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the adjustments, now looks good. Just modified the commit message for a consistent changelog.

@xsuchy @psss
Allow skipping events that are not reportable
ffa7820 
E.g. lunch break, focus block, deadline reminders.
@psss psss merged commit ffa7820 into psss:main Dec 13, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@psss psss psss approved these changes

Assignees

@psss psss

Labels
plugin | google plugins
Projects
None yet
Milestone
0.22
Development

Successfully merging this pull request may close these issues.
2 participants
@xsuchy @psss